shudd3r / filesystem / 7061102252

100%

push

github

Added emulated permissions to virtual filesystem

TODO Fixes:
- Discrepancies in isRemovable query vs remove validation
- Iteration of non-readable directories (UnexpectedValueException)
- Directory remove rights depend on descendant nodes

Future considerations for isRemovable:
The most straight forward approach for remove permissions in general
beside WRITE access for node's parent directory (cannot remove if cannot
create) would be READ+WRITE for node itself (excluding symlink).
Otherwise user could elevate their privileges by removing restricted
node and adding it back again.

That would also solve non-readable directory problem, which by local
filesystem (unix) rules can be removed when it's empty, but it's not
possible to check that before trying to remove it. That could lead
to directory contents being partially removed.

41 of 41 new or added lines in 8 files covered. (100.0%)

528 of 528 relevant lines covered (100.0%)

19.2 hits per line