pomerium / pomerium / 7053855279

45%

push

github

metrics: explicitly set Accept header (#4774)

If a request is made to the Pomerium metrics endpoint with an Accept
header requesting the Prometheus protobuf exposition format, some
metrics will be missing from the response.

These missing metrics are obtained by replaying the incoming request to 
an OpenCensus metrics exporter. This exporter honors the request for the
protobuf format, however Pomerium expects this response to be in the 
text format.

We can avoid this mismatch by explicitly requesting the text format from
the OpenCensus exporter, regardless of the incoming request's Accept
header.

(Note: the Pomerium metrics endpoint always responds with text format 
metrics, even if the protobuf format is requested.)

2 of 2 new or added lines in 1 file covered. (100.0%)

14519 of 23144 relevant lines covered (62.73%)

117.55 hits per line