skeema / skeema / 7039283732

92%

Build Type

push

github

Committed by evanelias

Commit Message

bug fix: UCA-14.0.0 collations in MariaDB 10.10+

MariaDB 10.10 introduced a number of new collations based on Unicode-14.0.0,
and as per https://jira.mariadb.org/browse/MDEV-27009 these collations are
represented quite differently in information_schema.collations relative to
all previous collations.

Skeema's introspection logic did not previously account for this, and the
representation of these new collations would cause JOINs to fail to match
properly in Skeema's introspection queries for tables and columns. As a
result, tables with a uca1400 default collation would be ignored entirely by
Skeema, as the failed join would cause them to not be returned in the result-
set.

It does not appear that these collations are widely used yet, and no Skeema
users have reported this problem to date. However, MariaDB JIRA comments
suggest that these collations will become defaults in a future MariaDB release
series, so it is important to handle them properly ahead of time.

This commit fixes handling of these collations by removing all joins to
information_schema.collations entirely. In addition to solving the uca1400
bug, this may have some minor performance benefits, for all database flavors.

This commit also includes some internal refactors to charset and collation
SHOW CREATE TABLE logic; improvements to test helper functions; and
introspection integration test coverage for uca1400 collations in MariaDB
10.10+.

Run Details

87 of 89 new or added lines in 5 files covered. (97.75%)

1 existing line in 1 file now uncovered.

9575 of 10252 relevant lines covered (93.4%)

1.12 hits per line