tarantool / tarantool / 7032685663

88%

Build Type

push

github

Committed by sergos

Commit Message

replication: send anonymous replica version id

Starting with commit f1c2127d4367 ("replication: add META stage to JOIN")
replication master appends a special section, called IPROTO_JOIN_META to
the initial snapshot sent to the replica. This section contains the
latest raft term and synchronous transaction queue owner and term.

The section is only sent to nodes, which have a non-zero version_id.
For some reason, version_id encoding for FETCH_SNAPSHOT (analog of JOIN
for anonymous replicas) wasn't added in that commit, so anonymous
replicas do not receive synchronous queue state.

This leads to them raising ER_SPLIT_BRAIN errors later after join, when
the first synchronous row arrives.

In order to fix this, start encoding version_id in FETCH_SNAPSHOT
requests.

Closes #9401

@TarantoolBot document
Title: new field in `IPROTO_FETCH_SNAPSHOT` request

`IPROTO_FETCH_SNAPSHOT` request was bodyless (only contained a header)
until now, but now it receives a body with a single field:
`IPROTO_SERVER_VERSION` : MP_UINT -- an encoded representation of the
server version of a replica issuing the request.

Run Details

66005 of 118147 branches covered (0.0%)

20 of 21 new or added lines in 4 files covered. (95.24%)

42 existing lines in 22 files now uncovered.

98163 of 113080 relevant lines covered (86.81%)

2656688.02 hits per line