23052
7%

Ran 28 Nov 2023 11:42AM UTC

Jobs 1

Files 472

Run time 1min

Badge

Embed ▾

Committed 28 Nov 2023 11:30AM UTC coverage: 7.031%. Remained the same

Build # 23052

Build Type

push

github

Committed by

web-flow

Commit Message

fix: allow reuse of dispatch queues between fsevents in macOS (#9009)

Previously, the code waiting on `dq->dq_finished` would get notified in
`dune_fsevents_dispatch_queue_wait_until_stopped` that the dispatch
queue had completed running. This would lead to the dispatch queue being
marked as `Stopped` on the OCaml side, even though the dispatch queue
could be passed into `Fsevents.start` again.

This change now tracks the number of fsevents streams in a
`fsevents_streams` counter so that `Dispatch_queue.wait_until_stopped`
will only return when an exception is raised or if all streams have been
stopped, restoring the original behavior in the code that used a runloop.

Fixes #9004. Fixes #8910.

Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>

Run Details

2812 of 39994 relevant lines covered (7.03%)

28482.04 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	23052.1	28 Nov 2023 11:42AM UTC	0	7.03	GitHub Action Run

Source Files on build 23052

Detailed source file information is not available for this build.

ocaml / dune / 23052
7%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23052

ocaml / dune / 23052 7%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 23052

ocaml / dune / 23052
7%

README BADGES
x