supabase / gotrue / 7006834104

65%

push

github

feat: password sign-up no longer blocks the db connection (#1319)

Password sign-up would perform the password hashing while a database
connection is open, thereby blocking it unnecessarily for tens of
milliseconds. This can result in behavior where just a few password
sign-up calls could slow down Auth entirely as the password hashing
causes pool exhaustion and thus increased latency across all Auth APIs
not just the password sign-up calls.

The hashing is done inside `models.NewUser()` making it very difficult
to refactor properly. Therefore, the model object generation is now
moved as a function of `api.SignupParams.ToUserModel()`. If these params
contain a password, the code is refactored to move the model generation
outside of the database transaction.

53 of 96 new or added lines in 5 files covered. (55.21%)

7624 of 11636 relevant lines covered (65.52%)

54.1 hits per line