Unleash / unleash-client-java / #1619

84%

master: 89%

Build Type

push

Committed by web-flow

Commit Message

fix: change seed for variantutils to ensure fair distribution (#220)

Background
After a customer reported that variant distribution seemed skewed we performed some testing and found that since we use the same hash string for both gradual rollout and variant allocation we'd reduced the set of groups we could get to whatever percentage our gradual rollout was set.

Example
Take a gradualRollout of 10%, this will select normalized hashes between 1 and 10, when we then again hash the same string that gave us between 1 and 10, but with modulo 1000 for variants, this will only give us 100 possible groups, instead of the expected 1000.

Fix
Force the normalization to accept a seed, and make sure to use a new seed when normalizing the variant distribution hash.

Worth noting
This will require release 9.0.0, since we're changing the signature of public methods.

Run Details

14 of 14 new or added lines in 6 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

1845 of 2197 relevant lines covered (83.98%)

0.84 hits per line