cofacts / rumors-line-bot / 6957663668

91%

Build Type

push

github

Committed by web-flow

Commit Message

Fix choosing reply action (#373)

This PR fixes [the release blocker found in 20231115 release test](https://g0v.hackmd.io/vAUg0WtvTAi0rzJ7E1spnQ#%E2%9B%94%EF%B8%8F-Release-Blockers).

refactor(webhook): map state and payload in createPostbackAction
- we don't touch PostbackActionData in chatbotState because we don't want to change ChatbotPostbackHandlerParams; which makes calling postback more difficult

refactor(webhook): type yes/no postback handlers
- `return input satisfies never` is to ensure all input enum has its own `case` in switch statement.
- It's called exhaustive switch. Ref: https://stackoverflow.com/a/75217377/1582110

## Screenshot
1. Choose 1st article, list replies for 1st article
2. Choose 2nd article, list replies for 2nd article
3. Choose a reply for 1st article, show link to 1st article
4. Choose a reply for 2nd article, show link to 2nd article

![1700542535241](https://github.com/cofacts/rumors-line-bot/assets/108608/69aeabce-6674-48c9-8360-2acd2c03b766)
![1700542535700](https://github.com/cofacts/rumors-line-bot/assets/108608/bd41ded9-b7ab-4094-a787-8553d2d3413d)

Run Details

472 of 563 branches covered (0.0%)

Branch coverage included in aggregate %.

11 of 13 new or added lines in 3 files covered. (84.62%)

36 existing lines in 2 files now uncovered.

977 of 1053 relevant lines covered (92.78%)

12.37 hits per line