6950254806
61%

Ran 21 Nov 2023 10:39PM UTC

Jobs 2

Files 95

Run time 11s

Badge

Embed ▾

Committed 21 Nov 2023 10:24PM UTC coverage: 72.05% (-0.1%) from 72.147%

Build # 6950254806

Build Type

push

github

Committed by

web-flow

Commit Message

Replace gogo protobuf (#1256)

**What was changed?**

gogo/protobuf has been replaced with Google's official go compiler. 

**Why?**

gogo/protobuf has been deprecated for some time and the community is moving on, building new tools (like vtproto) atop google's v2 compiler.

**Breaking changes**

- `*time.Time` in proto structs will now be [timestamppb.Timestamp](https://pkg.go.dev/google.golang.org/protobuf@v1.31.0/types/known/timestamppb#section-documentation)
- `*time.Duration` will now be [durationpb.Duration](https://pkg.go.dev/google.golang.org/protobuf/types/known/durationpb)
- V2-generated structs embed locks, so you cannot dereference them willy-nilly. `go vet` will scream at you about this
- Proto enums will, when formatted to JSON, now be in `SCREAMING_SNAKE_CASE` rather than `PascalCase`. We decided (in discussion with the SDK team) that now was as good a time as any to rip the bandage off.

Note that history loading will not be impacted by the JSON changes: I rewrote history loading to dynamically fix incoming history JSON data (like all our other sdks); you can find this code in [my fork of our go API](https://github.com/tdeebswihart/temporal-api-go/blob/master/internal/temporalhistoryv1/load.go) alongside its tests.

Run Details

14351 of 19918 relevant lines covered (72.05%)

33972.26 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	6950254806.1	21 Nov 2023 10:39PM UTC	0	71.96	GitHub Action Run
2	6950254806.2	21 Nov 2023 10:40PM UTC	0	72.04	GitHub Action Run

Source Files on build 6950254806

Detailed source file information is not available for this build.

temporalio / sdk-go / 6950254806
61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6950254806

temporalio / sdk-go / 6950254806 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6950254806

temporalio / sdk-go / 6950254806
61%

README BADGES
x