• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

spesmilo / electrum / 6282054069911552
63%

Build:
DEFAULT BRANCH: master
Ran 20 Nov 2023 07:01PM UTC
Jobs 5
Files 79
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

20 Nov 2023 06:55PM UTC coverage: 59.134% (-0.02%) from 59.157%
6282054069911552

push

CirrusCI

SomberNight
wallet.bump_fee: the glorious return of BumpFeeStrategy :D

gui/qt/rbf_dialog.py (old) lines 57-64 were implementing logic that should not be part of GUI code.
Case in point, gui/qml/qetxfinalizer.py (old) lines 511-513 duplicated half of that logic but not the other half.
That logic is now moved to wallet.get_bumpfee_strategies_for_tx().

More context: a user on irc got confused when using the qml gui. They were sending "max" and wanted to bump_fee.
The qml gui selected the "preserve_payment" strategy by default, using which there was no solution, and the user
did not notice that the strategy can be altered (via the "method" dropdown). The qt gui had logic to select
"decrease_payment" by default in such a case (which does find a solution to bump) but this logic was not
duplicated in the qml gui.
Instead of duplicating the logic, this commit moves it to shared lib code.

10 of 28 new or added lines in 2 files covered. (35.71%)

1 existing line in 1 file now uncovered.

18879 of 31926 relevant lines covered (59.13%)

2.95 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6282054069911552.1 20 Nov 2023 07:01PM UTC 0
58.98
2 6282054069911552.2 20 Nov 2023 07:01PM UTC 0
58.98
3 6282054069911552.3 20 Nov 2023 07:01PM UTC 0
59.01
4 6282054069911552.4 20 Nov 2023 07:01PM UTC 0
59.0
5 6282054069911552.5 20 Nov 2023 07:11PM UTC 0
59.02
Source Files on build 6282054069911552
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #62820540...
  • 7f64ecc4 on github
  • Prev Build on master (#47540871...)
  • Next Build on master (#48929893...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc