linxGnu / gosmpp / 6914591414

82%

push

github

OnAllPdu users are now able to return a bool to close the bind (#120)

What: 
OnAllPdu setting did not allow users to report bind closing status. This
caused an io error when users responded to a unbind request.

Why:
The change allow users to send back a bool to let the app close the
bind, if needed, like with a unbind request.

How:
The OnAllPDU is called from handleOrClose function, that has a return
value to close the bind. The OnAllPdu will also have a bool return value
and that value is forward to the handleorClose function. If the
OnCallPdu is returned with a true value, handleOrClose will initiate the
close status, like it does without the OnAllPdu setting.

This change also include some other minor changes:
- using a Callback type, to align with existing code
- no need to check if return value of OnAllPDU is nil. Its a struck, it
will never be nil and all fields will have default values
- fix manual response example to align with new return bool on OnAllPdu
call

0 of 6 new or added lines in 1 file covered. (0.0%)

424 of 492 relevant lines covered (86.18%)

31.95 hits per line