1967
87%
dev: 88%

Ran 31 May 2016 05:31PM UTC

Jobs 2

Files 42

Run time 3min

Badge

Embed ▾

pending completion

Build # 1967

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Fix races caused by closing sendCh

We have multiple goroutines possibly writing to sendCh, so closing
sendCh causes races unless we add a ton of synchronization between
the goroutines.

In the relay path, we really don't want to add synchronization overhead
for every frame we're handling. The much simpler option is to avoid
closing sendCh, and instead use a separate channel to signal that the
writeFrames goroutine to end. The sendCh will be cleaned up by the
GC automatically when there's no references left to the channel.

It's possible to simplify (and reduce synchronization) in the standard
call path after this change, which can be done separately if we get a
performance benefit. Since the standard call path does much more than
the relay path, it is likely not going to affect performance as much.

Run Details

3781 of 4350 relevant lines covered (86.92%)

5423.79 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1967.1 (TEST_TIMEOUT_SCALE=20)	31 May 2016 05:31PM UTC	42	85.49	Travis Job 1967.1
3	1967.3 (TEST_TIMEOUT_SCALE=20)	31 May 2016 05:34PM UTC	42	86.33	Travis Job 1967.3

Source Files on build 1967

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1967
87%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1967

uber / tchannel-go / 1967 87% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1967

uber / tchannel-go / 1967
87%
dev: 88%

README BADGES
x