openSUSE / agama / 6905402699

72%

push

github

Merge pull request #877 from openSUSE/fix-storage-menuitems

[web] Fix broken storage links

During [migration to PF5](https://github.com/openSUSE/agama/pull/759), specifically when [moving to the new PF/Dropdown](https://github.com/openSUSE/agama/commit/2edc4e2d4#diff-88232d7f9cbb5db44dea461a2d5ed6727), a few options were unintentionally broken when their `href` prop were not properly renamed to `to`.

This [makes the PF/MenuItem to use a `<button>` instead of `<a>`](https://github.com/patternfly/patternfly-react/blob/7d2fd2678/packages/react-core/src/components/Menu/MenuItem.tsx#L139) inside an `<li>` when building the menu item, assigning the `href` HTML attribute to the latest, which has no effect at all.

As a result, users cannot navigate to these options through the UI, as it was the case in https://bugzilla.suse.com/show_bug.cgi?id=1217281

1297 of 1980 branches covered (0.0%)

Branch coverage included in aggregate %.

15082 of 19703 relevant lines covered (76.55%)

20.57 hits per line