safe-global / safe-modules / 6876657085

85%

push

github

Refactor Deployment Scripts (#154)

This PR refactors the deployments scripts to take advantage of
deployment tagging and network tagging. Correct deployment order is
guaranteed through the use of the `dependencies` feature.

First, it defines three network tags:
- `dev` used to tag “development” networks, such as public testnets
(Sepolia for example) and `localhost`. This ensures all required
contracts are deployed including the `EntryPoint` (which will land on
the same address as the reference v0.6.0 version by the mystical magic
of EVM `CREATE2`)
- `safe` used to additionally deploy Safe contracts (proxy factory and
singleton)
- `test` to deploy all contracts needed used for `hardhat test`. In
particular, this ensures that the `TestEntryPoint` contract is used for
the entry point deployment instead of the reference `EntryPoint`
contract

In addition, I added tags to all the different deployment groups to
`hardhat deploy --tags ...` work for redeploying specific contracts
instead of everything.

For example - when deploying on Görli:
```
$ npx hardhat deploy --network goerli
Nothing to compile
No need to generate any newer typings.
reusing "EntryPoint" at 0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789
deploying "AddModulesLib" (tx: 0xe060a563a39c96063fb9f1e094a383258)...: deployed at 0x8EcD4ec46D4D2a6B64fE960B3D64e8B94B2234eb with 200879 gas
deploying "Safe4337Module" (tx: 0xd9e3cf3feb3ac5f31120f4ab174fe935e)...: deployed at 0x4E6d4819dB440578caDE32563DD263FD15c2F536 with 1794049 gas
deploying "HariWillibaldToken" (tx: 0x191a78dc25f3ff3931d8a751f328202b5)...: deployed at 0x650d14991F1Dc8079D750e81c600b0E8F800aF8D with 1202554 gas
```

Note that the `EntryPoint` contract gets “reused” and matches the
official deployment (🎉) and only contracts that are needed for the
`runOp` script actually get deployed.

And when deploying on `... (continued)

20 of 20 branches covered (100.0%)

Branch coverage included in aggregate %.

27 of 27 relevant lines covered (100.0%)

13.56 hits per line