hluk / CopyQ / #4037

78%

master: 79%

Build Type

Pull #2544

travis-ci

Committed by hluk

Commit Message

Optimize string operations mainly on app initiation

The string literal conversion rules are listed below.

Keep "..." where it is used/passed as `const char *`.

    log("...", LogWarning)

    COPYQ_LOG("...")

    qgetenv("...")

    byteArray + "..."

    qobj.setProperty("...", value)

Prefer QLatin1String("...") where it will be used as QLatin1String as in
comparison or concatenation with QString:

    const QString str = QLatin1String("...") + str2;

    if (str == QLatin1String("...")) ...

    if (str.startsWith(QLatin1String("..."))) ...

    if (str.endsWith(QLatin1String("..."))) ...

Otherwise prefer QStringLiteral("...") where it will be used as QString.

    QStringLiteral("...").arg(...)

    const QString str = QStringLiteral("image/");

Note: There is `QLatin1String::arg()` but it was introduced in Qt 5.14.

See also: https://doc.qt.io/qt-5/qstring.html#QStringLiteral

Pull Request Pull Request #2544: Refactor

Run Details

86 of 112 new or added lines in 8 files covered. (76.79%)

70 existing lines in 6 files now uncovered.

18600 of 24987 relevant lines covered (74.44%)

25624.82 hits per line