tarantool / luajit / 6853810502

70%

tarantool/master: 93%

Build Type

push

github

Committed by igormunkin

Commit Message

sysprof: fix crash during FFUNC stream

Sometimes, the Lua stack can be inconsistent during the FFUNC execution,
which may lead to a sysprof crash during the stack unwinding.

This patch replaces the `top_frame` property of `global_State` with
`lj_sysprof_topframe` structure, which contains `top_frame` and `ffid`
properties. `ffid` property makes sense only when the LuaJIT VM state is
set to `FFUNC`. That property is set to the ffid of the fast function
that VM is about to execute.  In the same time, `top_frame` property is
not updated now, so the top frame of the Lua stack can be streamed based
on the ffid, and the rest of the Lua stack can be streamed as usual.

Also, this patch fixes the build via Makefile.original by adding the
`LJ_HASSYSPROF` flag support to it.

Resolves tarantool/tarantool#8594

Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Igor Munkin <imun@tarantool.org>
(cherry picked from commit 285a1b0a1)

Run Details

5335 of 5958 branches covered (0.0%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

8 existing lines in 2 files now uncovered.

20451 of 23231 relevant lines covered (88.03%)

698690.01 hits per line