tarantool / tarantool / 6824581063

88%

Build Type

push

github

Committed by locker

Commit Message

box: decrement BOX_SPACE_MAX

Currently, BOX_SPACE_MAX equals BOX_ID_NIL, which is used as an error
indicator in the box C API. As a result, if box_space_id_by_name()
returns BOX_ID_NIL, it's impossible to figure out whether there's no
space with the give name or the space exists and has the id equal to
BOX_SPACE_MAX.

Let's decrement BOX_SPACE_MAX to fix this issue. Since this may break
recovery, let's also introduce the new compatibility module option
`box_space_max` to allow the user revert to the old behavior.

Closes #9118

@TarantoolBot document
Title: Document `compat.box_space_max`

Please create an entry for the new compatibility module option at
https://tarantool.io/compat/box_space_max.

`compat.box_space_max` sets the max space id (`box.schema.SPACE_MAX`).
The old limit is 2147483647. The new limit is 2147483646. The limit was
decremented because the old value is used as an error indicator in the
box C API (it equals `BOX_ID_NIL`).

Run Details

65793 of 118316 branches covered (0.0%)

1 of 1 new or added line in 1 file covered. (100.0%)

67 existing lines in 22 files now uncovered.

97861 of 113226 relevant lines covered (86.43%)

2672251.29 hits per line