tarantool / luajit / 6815578963

70%

tarantool/master: 93%

Build Type

push

github

Committed by igormunkin

Commit Message

FFI: Fix pragma push stack limit check and throw on overflow.

Reported by Sergey Kaplun.

(cherry-picked from commit 433d7e8d8)

`cp->packstack` is the array of size `CPARSE_MAX_PACKSTACK` (7). Before
the patch, `cp->curpack` is checked to be less than
`CPARSE_MAX_PACKSTACK`, but then `cp->packstack` is accessed at
`cp->curpack + 1`, which is out of bounds, so `cp->curpack` value is
overwritten.

This patch fixes a condition and also adds the error throw when counter
is overflow (instead of rewriting a top `cp->packstack` value).

Sergey Kaplun:
* added the description and the test for the problem

Resolves tarantool/tarantool#9339
Part of tarantool/tarantool#9145

Reviewed-by: Igor Munkin <imun@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Igor Munkin <imun@tarantool.org>
(cherry picked from commit 7e1519756)

Run Details

5329 of 5956 branches covered (0.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

7 existing lines in 1 file now uncovered.

20418 of 23213 relevant lines covered (87.96%)

696182.02 hits per line