c-ares / c-ares / #230

92%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

OPT RR should support parsing key/value options (#602)

The OPT RR record has some seldom used options with a 16bit key and a binary value.  The current parser and writer was not supporting this.  This PR adds support.  The same format is also used for SVCB/HTTPS records, so getting this in there is necessary to support that RR type.

Also, we split the Binary record format into BIN and BINP, where BINP is an indicator that the binary data is _likely_ printable and will guarantee a NULL terminator.  This is helpful for those attempting to print RRs.

Fix By: Brad House (@bradh352)

Coverage Stats

72 of 150 new or added lines in 5 files covered. (48.0%)

2 existing lines in 1 file now uncovered.

6803 of 8292 relevant lines covered (82.04%)

2116.39 hits per line