• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Kong / ngx_wasm_module / 6802008362
95%

Build:
DEFAULT BRANCH: main
Ran 08 Nov 2023 05:54PM UTC
Jobs 9
Files 46
Run time 39s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Nov 2023 05:42PM UTC coverage: 90.98% (+0.03%) from 90.952%
6802008362

push

github

thibaultcha
refactor(proxy-wasm) improve pwexec resurrection and instance lifecycle

The main goal of this overhaul is to simplify `on_context_create`, make
it fully re-entrant *and* properly handle instance recycling at the same
time.

The way to do so, in my opinion, was to move `pwexec` creation where
`rexec` already was. In other words, always lookup the context id in the
instance rbtree, and if not found, create it. This means that
surrounding code also needed big overhauls. It also removes the
reference counting poor man's GC of the older implementation. The code
became really ugly by then so I took the time to also review this
module's code structure instead of making a *very* ugly commit.

This new ngx_proxy_wasm.c file should be much easier to read and follow
now.

One change I do not fully like is moving the `next_id` to a global
counter, but we do not have a "global proxy-wasm conf" object yet. I
also started thinking about pre-allocating a number of `pwexecs` (like
`worker_connections`) and use free/busy queue that all filter chains can
dip into to get a context id + context memory zone. Perhaps for a later
time.

476 of 518 new or added lines in 8 files covered. (91.89%)

19 existing lines in 2 files now uncovered.

7615 of 8370 relevant lines covered (90.98%)

18112.08 hits per line

Jobs
ID Job ID Ran Files Coverage
1 unit-ngx_1.25.3-wasmer-no_ssl-no_debug-no_hup-static - 6802008362.1 08 Nov 2023 05:57PM UTC 0
89.32
GitHub Action Run
2 unit-ngx_1.25.3-wasmer-ssl-debug-no_hup-static - 6802008362.2 08 Nov 2023 05:58PM UTC 0
90.75
GitHub Action Run
3 unit-ngx_1.25.3-v8-ssl-debug-no_hup-static - 6802008362.3 08 Nov 2023 06:02PM UTC 0
91.13
GitHub Action Run
4 unit-ngx_1.21.6-wasmer-ssl-debug-no_hup-static - 6802008362.4 08 Nov 2023 06:01PM UTC 0
90.7
GitHub Action Run
5 unit-ngx_1.25.3-wasmtime-ssl-debug-hup-static - 6802008362.5 08 Nov 2023 06:10PM UTC 0
90.23
GitHub Action Run
6 unit-openresty_1.21.4.2-wasmtime-ssl-debug-no_hup-dynamic - 6802008362.6 08 Nov 2023 06:16PM UTC 0
90.58
GitHub Action Run
7 unit-openresty_1.21.4.2-wasmtime-ssl-debug-no_hup-static - 6802008362.7 08 Nov 2023 06:17PM UTC 0
90.56
GitHub Action Run
8 unit-ngx_1.25.3-wasmtime-ssl-debug-hup-dynamic - 6802008362.8 08 Nov 2023 06:17PM UTC 0
90.26
GitHub Action Run
9 unit-ngx_1.25.3-wasmer-ssl-no_debug-no_hup-static - 6802008362.9 08 Nov 2023 05:54PM UTC 0
89.69
GitHub Action Run
Source Files on build 6802008362
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #6802008362
  • ecd78968 on github
  • Prev Build on main (#6756870878)
  • Next Build on main (#6933593002)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc