neo-project / neo / 6795894094

77%

push

github

Improved scheme for Conflicts attribute storing and pricing (#2913)

* Ledger: change conflict records storage scheme

This commit is a part of #2907: it implements conflict records storage scheme discribed
in https://github.com/neo-project/neo/issues/2907#issuecomment-1722506014.

The short scheme description:

Do not store the list of conflicting signers in the Ledger's conflict record value.
Instead, put each conflicting signer in the conflict record key so that the
reculting key is: {Prefix_Transaction, <conflict hash>, <signer>}, and the value
is {<block index>}.

As an optimisation, for each conflict record store the dummy stub where the
key is {Prefix_Transaction, <conflict hash>} and the value is {<block index>}. This optimisation
allows to reduce DB read requests during newly-pooled transaction verification for
those transactions that do not have any on-chained conflicts.

Also, IsTraceableBlock check is added for on-chain conflicts verification. It is
needed to avoid situations when untraceable on-chained conflict affects the
newly-pooled transaction verification.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* UT_MemoryPool: remove unused test

Malicious_OnChain_Conflict was constructed incorrectly (see the comment in the end of
the test) and was replaced by the proper TestMaliciousOnChainConflict test in
UT_Blockchain.cs way back ago in
https://github.com/neo-project/neo/pull/2818/commits/0c06c915e.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Policy: introduce fee for Conflicts attribute

This commit implements Conflicts attribute policy described in
https://github.com/neo-project/neo/issues/2907#issuecomment-1722506014.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* *: remove remnants of ConflictsFee in native Policy

ConflictsFee logic was replaced by the generic attribute fee mechanism
implemented in #2916.

Signed-off-by: Anna Shaleva <... (continued)

3036 of 4898 branches covered (0.0%)

Branch coverage included in aggregate %.

20 of 21 new or added lines in 4 files covered. (95.24%)

10166 of 13382 relevant lines covered (75.97%)

18092.69 hits per line