ocaml / dune / 22485

7%

Build Type

push

github

Committed by web-flow

Commit Message

pkg: add Dune_pkg.Local_package module (#9103)

Thus far we've been using `OpamFile.OPAM.t` to represent local packages
in our package management code, mainly because dune's `Package.t` type
is in the `dune_rules` library which `dune_pkg` can't depend on (to
avoid a dependency cycle). This change adds a minimal
`Dune_pkg.Local_package.t` type containing the information about a local
package that is relevant to package management from which a
`OpamFile.OPAM.t` can be derived. This also replaces the
`OpamSolver.local_package` type which was opam-specific and contained an
unused `file` field (removed in this change).

Having our own local package type rather than depending on opam's will
help clarify the intent of code through types and reduce the degree to
which pkg's api is opam-specific. It also means we can easily implement
`to_dyn` and other helpful functions without having to worry about how
to represent values of `OpamFile.OPAM.t`.

Also in this change the `Package_version.*_opam` conversion functions
are renamed to `Package_version.*_opam_package_version` to clarify that
they convert between `Package_version.t` and `OpamPackage.Version.t`
(rather than `OpamVersion.t`) and for consistency with
the `Package_name.*_opam_package_version` functions.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>

Run Details

2 of 18 new or added lines in 5 files covered. (11.11%)

1 existing line in 1 file now uncovered.

2768 of 38613 relevant lines covered (7.17%)

29500.42 hits per line