hathitrust / hathifile_history / 6787928068

100%

push

github

Dev 970 tests (#1)

DEV-970 add tests for hathifile_history
- The focus of this ticket is adding tests, but I am also Dockerizing as a transient development and CI aid.
- Main bullet points to follow are commits in chronological order:
- Fix issues in `records.rb` identified in the process of writing tests:
  - `ids_from_line`: `split` was producing cid and rest of line in one field; increase split limit to 5.
  - `intify_record_id`: `gsub!` did not play well with frozen strings; replace with `gsub`.
  - `self.yyyymm_from_filename`:
    - would raise `ArgumentError` prior to `exit()`; added `exception: false`
    - add optional `logger:` param since it was using some kind of global `LOGGER` variable from one of the `bin/` scripts (I guess?), and to keep `rspec` output less verbose
- Dockerization boilerplate (should be largely ignorable by reviewers):
  - Everything in `.github/`
  - `Dockerfile*` and `docker-compose.yml`
  - `Gemfile*` additions related to test coverage (`simplecov`)
  - `bin/setup` and `bin/console` convenience scripts
  - `.gitignore` for coverage directory and `.rspec_status`
- Add tests, helper, and some fixtures all under `spec/`.
- Add minimal Docker setup instructions to README.
- Appease `standardrb`.
- I'd like to have standardized on Ruby 3.2 but after trying this branch out on sidecar (which has 3.0.2 I believe) settled on 3.1. I did not run `add_monthly_and_dump_redirects.rb` to completion on sidecar but made sure it could get underway with some locally-copied files. When this runs in k8s we'll go with 3.2+.
- Checked with Bill before removing `find_missing_ids.rb` from the top level -- it was a one-off script that need not be retained.

17 of 17 new or added lines in 2 files covered. (100.0%)

176 of 176 relevant lines covered (100.0%)

15.61 hits per line