1963
86%
dev: 88%

Ran 28 May 2016 12:15AM UTC

Jobs 3

Files 42

Run time 1min

Badge

Embed ▾

pending completion

Build # 1963

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Only add connection to ch.conns if it's active

If a connection becomes active, and then closes almost immediately, then
it's possible that the close is handled before onActive is done
processing which leads to adding a inactive connection to ch.conns.

This causes the test TestTimeoutCallsThenClose to fail with state
mismatch since the number of connections has changed.

Check the connection state before adding it to the channel to avoid this
race.

Run Details

3749 of 4331 relevant lines covered (86.56%)

7815.81 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1963.1 (TEST_TIMEOUT_SCALE=20)	28 May 2016 12:15AM UTC	42	86.33	Travis Job 1963.1
2	1963.2 (TEST_TIMEOUT_SCALE=20)	28 May 2016 12:16AM UTC	42	85.32	Travis Job 1963.2
3	1963.3 (TEST_TIMEOUT_SCALE=20)	28 May 2016 12:16AM UTC	42	84.95	Travis Job 1963.3

Source Files on build 1963

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1963
86%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1963

uber / tchannel-go / 1963 86% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1963

uber / tchannel-go / 1963
86%
dev: 88%

README BADGES
x