1948
87%
dev: 88%

Ran 27 May 2016 06:36PM UTC

Jobs 4

Files 42

Run time 15min

Badge

Embed ▾

pending completion

Build # 1948

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Only add new active connections if channel is active

We previously checked if the channel was active using a read lock, but
this could go stale, as the channel could be closed between the time the
check was done and the connection being added -- and the connection
would be left in an active state, causing the channel to never close.

To avoid this, we now check the state and add the connection atomically.

If the connection is not added, it means the channel is closed, and so
we close the connection to avoid leaving a rogue TCP connection.

Run Details

3743 of 4326 relevant lines covered (86.52%)

12552.08 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1948.1 (TEST_TIMEOUT_SCALE=20)	27 May 2016 06:36PM UTC	86.15	Travis Job 1948.1
2	1948.2 (TEST_TIMEOUT_SCALE=20)	27 May 2016 06:38PM UTC	85.12	Travis Job 1948.2
3	1948.3 (TEST_TIMEOUT_SCALE=20)	27 May 2016 06:37PM UTC	85.86	Travis Job 1948.3
4	1948.4 (TEST_TIMEOUT_SCALE=20)	27 May 2016 06:52PM UTC	85.13	Travis Job 1948.4

Source Files on build 1948

Detailed source file information is not available for this build.

uber / tchannel-go / 1948
87%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1948

uber / tchannel-go / 1948 87% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1948

uber / tchannel-go / 1948
87%
dev: 88%

README BADGES
x