albertms10 / music_notes / 6685998822

100%

push

github

feat(tuning)!: :boom: add `PythagoreanTuning` tuning system (#273)

* feat(tuning)!: :boom: create new `JustIntonation` tuning system and reorganize classes

* feat(positioned_note)!: :boom: move `referenceNote` inside `tuningSystem`

* style(frequency): :art: add missing trailing comma

* test(equal_temperament): :recycle: remove empty group

* test(equal_temperament): :recycle: rewrite constant references

* docs(tuning): :book: move `generatorCents` documentation to `TuningSystem`

* docs(just_intonation): :book: address full stop typo

* refactor(just_intonation): :recycle: move `pythagoreanComma` getter below

* fix(just_intonation): :bug: address intervals higher than an octave

* test(tuning): :test_tube: add test cases

* test(just_intonation): :test_tube: add test cases for basic chromatic steps

* refactor(tuning_system): :recycle: use `chromaticDivisions` to define `octaveCents`

* feat(just_intonation): :sparkles: return ratio for commas

* refactor(just_intonation): :recycle: use `Cent`, `Ratio` classes

* refactor(just_intonation): :fire: remove `centsFromNote` method

Instead, call `ratioFromNote().cents`

* refactor: :recycle: rename `ratioFromNote` → `ratio`

* docs(just_intonation): :book: add missing period

* refactor(just_intonation): :recycle: simplify `octaveDelta` in `ratio`

18 of 18 new or added lines in 3 files covered. (100.0%)

888 of 888 relevant lines covered (100.0%)

2.23 hits per line