tari-project / tari / 6667936732

60%

push

github

feat: ban bad block-sync peers (#5871)

Description
---
- Added a check to ban a misbehaving peer after block sync when not
supplying any or all of the blocks corresponding to the accumulated
difficulty they claimed they had.
- Added a check in the RPC block-sync server method not to try and
supply blocks if it does not have both blocks corresponding to the start
and end hash in its chain.
- Moved all block sync RPC errors to the short ban category from the
no=ban cetegrory.
- Added happy path and ban integration-level unit tests for block sync.

Motivation and Context
---
The new unit tests that were added highlighted some issues where sync
peers are not banned for their bad behaviour.

How Has This Been Tested?
---
Added new integration-level unit tests.

What process can a PR reviewer use to test or verify this change?
---
- Code walk through.
- Review and run unit tests .

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

---------

Co-authored-by: SW van Heerden <swvheerden@gmail.com>

53 of 53 new or added lines in 10 files covered. (100.0%)

74215 of 97879 relevant lines covered (75.82%)

204105.65 hits per line