zooniverse / Panoptes-Front-End / 6644458824

56%

push

github

Add deleteIfOutOfBounds to markings renderer (#6889)

* Add deleteIfOutOfBounds to markings renderer

Store a list of current marking tools in the markings renderer. Check deleteIfOutOfBounds for each tool on every update and delete any tools that are outside the subject.

The subject bounds are calculated from the SVG image, for image subjects, or from the SVG scaled size rectangle otherwise.

* More robust checking in MarkingInitializer
Marks can now vanish mid-drag, so we need to check their existence before using them.

* Rewrite deleteIfOutOfBounds as JS

* Track the array index for new marks

7283 of 12998 branches covered (0.0%)

Branch coverage included in aggregate %.

49 of 49 new or added lines in 13 files covered. (100.0%)

8591 of 14832 relevant lines covered (57.92%)

104.28 hits per line