43081j / eslint-plugin-lit / 6629573358

99%

push

github

fix(no-this-assign-in-render): explicit left hand side traversal (#185)

The esquery we were using was too wide in that it would match a `.left`
at _any_ level.

This meant the following code would match:

```ts
render() {
  x = this.foo || 123;
}
```

As a `LogicalExpression` has a left just like an `AssignmentExpression`.

Since esquery doesn't support relative direct child selection (i.e.
using `:has(> foo)`), we are now selecting the left side node and
reporting on the parent instead.

547 of 628 branches covered (0.0%)

Branch coverage included in aggregate %.

949 of 968 relevant lines covered (98.04%)

51.31 hits per line