tari-project / bulletproofs-plus / 6589206851

98%

push

github

fix: add check for unused deserialization data (#83)

Adds an extra check for unused deserialization data to ensure proof
serialization is canonical. Removes redundant length checks.

Currently, serialized proof data is read as
[chunks](https://github.com/tari-project/bulletproofs-plus/blob/e01c38018/src/range_proof.rs#L1017-L1020)
and
[tuples](https://docs.rs/itertools/latest/itertools/trait.Itertools.html#method.tuples)
for parsing purposes. Each of these functions can have leftover data.
However, existing length checks ensure such conditions cannot occur.

This PR replaces the length checks with a final check that there is no
leftover data. This helps to assert that serialization is canonical and
simplifies deserialization.

Closes #82.

21 of 21 new or added lines in 1 file covered. (100.0%)

2080 of 2137 relevant lines covered (97.33%)

2603.88 hits per line