yitsushi / totp-cli / 6585551217

27%

master: 20%

push

github

fix: empty string when new newline at the end of stdin (#96)

The code reads the token from `stdin` until newline. If there is no
newline, it counts the content as empty string.

We use `bufio.NewReader` with `reader.ReadString('\n')` which "reads
until the first occurrence of delim in the input". When it can't find a
newline character before the stream ends we return with an error and an
empty string.

Fix: As `reader.ReadString` returns with the content before the error in
all cases, we can return with the content even if we meet an error.

Note: We should check if the error was EOF on caller side everywhere.

Fixes #95

References:
* https://github.com/yitsushi/totp-cli/issues/95

Signed-off-by: Efertone <efertone@pm.me>

1 of 1 new or added line in 1 file covered. (100.0%)

152 of 384 relevant lines covered (39.58%)

3.78 hits per line