tarantool / tarantool / 6571927679

88%

push

github

box: call tuple_free from box_free

There are four problems we have to address to make this possible:

 1. memtx_engine_shutdown may delete the tuple referenced by
    box_tuple_last so that tuple_free, which is called later by
    box_free, will crash trying to free it. Fix this by clearing
    box_tuple_last in memtx_engine_shutdown.

 2. tuple_format_destroy and tuple_field_delete, called by it, expect
    all constraints to be detached. Let's destroy the constraints if
    this isn't the case. This effectively reverts commit 7a87b9a594ee5
    ("box: do not call constraint[i].destroy() in
    tuple_field_delete()").

 3. tuple_field_delete, called by tuple_format_destroy, expects the
    default value function to be unpinned. Let's unpin it if this isn't
    the case. To avoid linking dependencies between the tuple and box
    libraries, we have to introduce a virtual destructor for
    field_default_func.

 4. The tuple_format unit test calls tuple_free after box_free. If
    box_free calls tuple_free by itself, this leads to a crash. Fix this
    by removing tuple_free and tuple_init calls from the test.

Closes #9174

NO_DOC=code health
NO_CHANGELOG=code health
NO_TEST=checked by existing tests

65057 of 116996 branches covered (0.0%)

17 of 17 new or added lines in 5 files covered. (100.0%)

96866 of 112087 relevant lines covered (86.42%)

2655215.33 hits per line