cofacts / rumors-line-bot / 6564798300

91%

push

github

[1] Cleanup unused field, fix and define action payload type (#366)

- [refactor: remove issuedAt](https://github.com/cofacts/rumors-line-bot/commit/8906575d3)
  - `issuedAt` logic was initially introduced before 2018 (https://github.com/cofacts/rumors-line-bot/pull/113/files) and was long replaced by sessionId
  - This PR removes the remaining `issuedAt`
- [fix(chatbotState): replace `PostbackEvent` with actual type used in handlers](https://github.com/cofacts/rumors-line-bot/commit/d2cf99238) 
  - The new type describes the weird payload event (`type: payload` + `input`) that the chatbot uses
  - Many`as ChatbotEvent` can be removed as the current `ChatbotEvent` can precisely describe the event being passed
- [refactor(webhook): Read / write of postback data is protected by type](https://github.com/cofacts/rumors-line-bot/pull/366/commits/f23f66858)
  - Define the payload action that is currently being used
- [refactor(gql): narrow the type of GraphQL response](https://github.com/cofacts/rumors-line-bot/commit/9bc912b98)
  - Better `data` & `error` that matches the actual scenario

474 of 553 branches covered (0.0%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 5 files covered. (100.0%)

982 of 1057 relevant lines covered (92.9%)

12.18 hits per line