Qiskit / qiskit / 6550514240

88%

push

github

Deprecate Unroller pass (#10607)

* Deprecate Unroller pass

* small fix

* black

* add release note

* fix test

* fix test again

* fix test again

* fix visualization tests

* update visual tests

* try to fix circuits

* Adjust qpy backwards compat tests to handle change in control definition

In this PR by switching the internal use of the Unroller to the
BasisTranslator for the add_control.py module results in a different
definition for the generated controlled gate than was done in previous
releases this causes the qpy backwards compat tests to fail. The qpy
backwards compatibility tests generate qpy files with every historical
release of qiskit (that had qpy support) and valdiates that if we load
those qpy files with the current state of the main branch (plus a PR
under test) that the loaded  circuits are identical to running the same
code to generate the circuit. However, because of this divergence due to
an internal change in add_control() the circuits are no longer 100%
identical, but are still equivalent. To address this, a new option is
added to the test suite to give an option when this situation occurs to
test for unitary equivalence instead of a instruction for instruction
identical circuit. This is then used for the control circuits.

* Expand release notes

* Ensure we are explicitly warning on transpile()

This commit adds an explicit user facing warning for places where the
transpiler is typically invoked by users. The normal entry point for
users that are using the unroller is to call
`transpile(..., translation_method="unroller")` and they don't work
directly with the `Unroller` pass. This means the deprecation warning
would be hidden from most users because the warning would not point to
user code and the default filters will suppress it. This commit adds an
explicit warning to transpile() and generate_preset_pass_manager() when
the unroller is requested as the translation method to ensure users see
the warning and know how to ... (continued)

16 of 16 new or added lines in 4 files covered. (100.0%)

74026 of 85025 relevant lines covered (87.06%)

91431.1 hits per line