c-ares / c-ares / #100

92%

push

travis-ci

introduce ares_bool_t datatype (#570)

c-ares currently uses int for boolean, which can be confusing as there are some functions which return int but use '0' as the success condition. Some internal variable usage is similar. Lets try to identify the boolean use cases and split them out into their own data type of ares_bool_t. Since we're trying to keep C89 compatibility, we can't rely on stdbool.h or the _Bool C99 data type, so we'll define our own.

Also, chose using an enum rather than say unsigned char or int because of the type safety benefits it provides. Compilers should warn if you try to pass, ARES_TRUE on to a ares_status_t enum (or similar) since they are different enums.

Fix By: Brad House (@bradh352)

133 of 133 new or added lines in 15 files covered. (100.0%)

5075 of 5881 relevant lines covered (86.29%)

11049.63 hits per line