ooni / probe-cli / 6497263860

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(buildtool): let libevent use OpenSSL's pkgconfig (#1369)

This diff modifies `./internal/cmd/buildtool` to (1) stop removing
OpenSSL's pkgconfig, (2) use such a pkgconfig during libevent's
`./configure` step, and (3) make sure libevent's install does not remove
OpenSSL's pkgconfig.

We're implementing changes (1) and (2) because libevent fails to
properly configure for iOS if you have a system with homebrew with
OpenSSL@3 installed. Unless we force the `PKG_CONFIG_PATH`, libevent's
`configure` uses the OpenSSL@3 headers and library installed with
homebrew rather than the ones we cross compiled.

Change (3) is there because otherwise we cannot recompile libevent
without recompiling OpenSSL, since the libevent build fails unless we
have a suitable OpenSSL pkgconfig, as explained before.

This diff was extracted and refined from
https://github.com/ooni/probe-cli/pull/1366.

The reference issue is: https://github.com/ooni/probe/issues/2564.

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

23813 of 29733 relevant lines covered (80.09%)

37.41 hits per line