ooni / probe-cli / 6494044213

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(buildtool): use list for OpenSSL ./Configure flags (#1367)

We currently have a string variable in `cBuildEnv` named
`OPENSSL_API_DEFINE` that we append to OpenSSL's `./Configure`
invocation to force using the proper Android API. However, for building
for iOS (a need documented by
https://github.com/ooni/probe/issues/2564), we need a list of strings,
because there is more than a single scalar that we need to append to the
`./Configure` invocation (as shown by the MVP implementation at
https://github.com/ooni/probe-cli/pull/1366).

Hence, this diff, which introduces a string list named
`OPENSSL_POST_COMPILER_FLAGS` that contains strings to append to the
`./Configure` command line _after_ the OS/compiler flag. We specifically
named the variable "post compiler" because there is another variable in
the same `cBuildEnv` struct called `OPENSSL_COMPILER`.

Run Details

61 of 62 new or added lines in 4 files covered. (98.39%)

3 existing lines in 2 files now uncovered.

23798 of 29719 relevant lines covered (80.08%)

33.1 hits per line