ooni / probe-cli / 6484777183

80%

master: 84%

Build Type

Pull #1363

github

Committed by bassosimone

Commit Message

refactor(riseupvpn): handle failing API and simplify test keys

This diff incorporates part of what has been implemented by @cyBerta in
https://github.com/ooni/probe-cli/pull/1125 in response to my review.

I have omitted the work to use the geo service to figure out which are
the correct gateways to test for now, which allows me to simplify the
diff that I am committing to the master branch.

The spirit of the changes is the following:

1. reduce the test keys to the minimum required by riseup to
process the experiment results;

2. skip TLS verification if we cannot fetch the CA certificate
and unconditionally fetch information about gateways.

The major difference between this diff and the above-mentioned pull
request is that I did not feel good to keep the `api_failure` name
with a different type, which seems like a very breaking change,
and instead I introduced a new type called `api_failures`.

This work is part of https://github.com/ooni/probe/issues/1432.

Pull Request Pull Request #1363: refactor(riseupvpn): handle failing API and simplify test keys

Run Details

17 of 17 new or added lines in 1 file covered. (100.0%)

14 existing lines in 5 files now uncovered.

23771 of 29695 relevant lines covered (80.05%)

40.72 hits per line