ooni / probe-cli / 6480833691

84%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add echcheck to the experimental suite (#1217)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1453
https://github.com/ooni/probe/issues/2547
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
https://github.com/kelmenhorst/spec/tree/echcheck-spec
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Description

This diff does two things:

1. Add `echcheck` to the experimental nettest suite. We do not provide
input which causes the experiment to use the default URL
`https://crypto.cloudflare.com/cdn-cgi/trace` (URL
[proposed](https://github.com/ooni/probe/issues/1453#issuecomment-1699380640)
by @eighthave). With this single input configuration we can collect the
first experimental ECH measurements.

2. Add netem tests to `echcheck`, while keeping a "real-internet" test
to connect to an ECH-enabled server.

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>

Run Details

1 of 7 new or added lines in 2 files covered. (14.29%)

7 existing lines in 2 files now uncovered.

23822 of 29718 relevant lines covered (80.16%)

34.52 hits per line