ooni / probe-cli / 6480457681

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat: mvp of conditionally enabling experiments (#1355)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/2553
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Description

We have a class of experiments that I call experimental experiments.
These are experiments that we just added, so we're not 100% sure about
them, or experiments that are historically flaky, so we want to be
defensive.

Currently, riseupvpn and echechk fall into this class.

The idea of this diff is to implement the functional specification
described by issue https://github.com/ooni/probe/issues/2553.

While there, make sure we have more robust testing for the
`./internal/registry` package.

While there, make sure package creation logic lives in
`./internal/registry` rather than in `./internal/engine`.

Run Details

36 of 42 new or added lines in 5 files covered. (85.71%)

4 existing lines in 1 file now uncovered.

23812 of 29712 relevant lines covered (80.14%)

35.64 hits per line