share / sharedb / 6472311395

97%

push

github

♻  Throw error for pending ops on hard rollback (#626)

Our current flow for handling the rollback swallows some errors and discards pending ops.

1. Whenever we do hard rollback and fetch for hard rollback fails we should throw the error so that user is informed that something really wrong happen.
2. Whenever we preform the hard rollback and we have some pending ops and the `ERR_OP_PENDING_OP_SUBMIT_REJECTED` error is thrown we should soft reject, as this error is meant for the user to reject some of the ops from submition to DB, however we should throw for all the pending ops s the pending ops would be otherwise just discarded. This way we at least allow user to handle the error
3. For the soft rollback we just resolve for this error and allow pending ops to be submitted to the server.

1572 of 1783 branches covered (0.0%)

16 of 16 new or added lines in 1 file covered. (100.0%)

3363 of 3448 relevant lines covered (97.53%)

869.85 hits per line