c-ares / c-ares / #90

92%

push

travis-ci

ares_status_t enum for status codes (#567)

The list of possible error codes in c-ares was a #define list. This not only doesn't provide for any sort of type safety but it also lacks clarification on what a function may return or what it takes, as an int could be an ares status, a boolean, or possibly even a length in the current code.

We are not changing any public APIs as though the C standard states the underlying size and type of an enum is int, there are compiler attributes to override this as well as compiler flags like -fshort-enums. GCC in particular is known to expand an enum's width based on the data values (e.g., it can emit a 64bit integer enum).

All internal usages should be changed by this PR, but of course, there may be some I missed.

Fix By: Brad House (@bradh352)

126 of 126 new or added lines in 19 files covered. (100.0%)

5068 of 5880 relevant lines covered (86.19%)

11054.95 hits per line