ooni / probe-cli / 6470487342

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: anomaly with android_dns_cache_no_data and inconsistent dns (#1211)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/2499
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Summary

This diff changes the `summary.go` algorithm of Web Connectivity v0.4 to
handle `android_dns_cache_no_data` as an anomaly when the DNS is
inconsistent. We continue handling `dns_nxdomain_error` as an anomaly
when the DNS is inconsistent, as demonstrated by the fact that the
corresponding netem test is still passing.

This diff also bumps the version number to v0.4.3. Version v0.4.2 did
not handle this case, which caused measurements to be marked as failed
as documented by https://github.com/ooni/probe/issues/2499.

This diff is also related to https://github.com/ooni/probe/issues/2029,
in the sense that it is slightly improving our analysis results when the
is an NXDOMAIN error (even if it's masked by Android's DNS cache
behavior).

While there, add empty lines to improve the code readability.

Run Details

7 of 7 new or added lines in 4 files covered. (100.0%)

5 existing lines in 1 file now uncovered.

23630 of 29681 relevant lines covered (79.61%)

40.72 hits per line