Ran
|
Jobs
3
|
Files
432
|
Run time
14s
|
Badge
README BADGES
|
push
github
Remove troubleshoot from here Summary: Simplify how messages (state updates) are shown in Flipper UI. This main change was introduced as a way to show the 'Start' server button whenever we were in a disconnected state. This is not as simple as the server may be restarting or the client may be even have reset the WS connection. Hence you the experience where this UI is shown and immediately dismissed. This UI is only ever shown if at one point the server was alive, period. So, in this case, either the server becomes available again OR the user quits the PWA/tab/browser and launches again. IMHO, this is a better experience that totally assuming the server is dead. In a next iteration, we can be more clever and have a timeout such that if after a set period of time the server doesn't become online, then we show a button to start (or force kill) the server. Reviewed By: aigoncharov Differential Revision: D49915698 fbshipit-source-id: 03fcc150e
4201 of 9877 branches covered (0.0%)
Branch coverage included in aggregate %.
8487 of 16019 relevant lines covered (52.98%)
278.5 hits per line
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 6418527813.1 | 432 |
48.98 |
GitHub Action Run | |
2 | 6418527813.2 | 432 |
48.98 |
GitHub Action Run | |
3 | 6418527813.3 | 432 |
48.96 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|