IntelPython / dpctl / 6395722032

86%

push

github

Check in of generic reduction templates and some reductions (#1399)

* Implements necessary sycl utilities for custom reductions

* Implements dpctl.tensor.max and dpctl.tensor.min

* Adds tests for min and max

* Reductions now set max_wg to the minimum of the max work group size and 2048
- This prevents running out of resources when using local memory on CPU

* max and min nan propagation fixed for CPU devices
- drops use of fetch_max/fetch_min for floats, which do not handle nans correctly

* Tweak to test_reduction_kernels

* Implements dpctl.tensor.argmax and argmin

* Tests for argmin and argmax

Also fixes argmin and argmax for scalar inputs

* Argmin and argmax now handle identities correctly

Adds a test for this behavior

Fixed a typo in argmin and argmax causing shared local memory variant to be used for more types than expected

* Replaced `std::min` with `idx_reduction_op_`

* reductions now well-behaved for size-zero arrays
- comparison and search reductions will throw an error in this case
- slips in change to align sum signature with array API spec

* removed unnecessary copies in reduction templates

* Refactors sum to use generic reduction templates

* Sum now uses a generic Python API

* Docstrings added for argmax, argmin, max, and min

* Small reduction clean-ups

Removed unnecessary copies in custom_reduce_over_group

Sequential reduction now casts before calling operator (makes behavior explicit rather than implicit)

* Added test for argmin with keepdims=True

* Added a test for raised errors in reductions

Also removed unused `_usm_types` in `test_tensor_sum`

* Removed `void` overloads from reduction utilities

These were unused by dpctl

* Added missing include, Identity to use has_known_identity

Implementation of Identity trait should call sycl::known_identity
if trait sycl::has_known_identity is a true_type.

Added IsMultiplies, and identity value for it, since ... (continued)

2439 of 2873 branches covered (0.0%)

Branch coverage included in aggregate %.

104 of 107 new or added lines in 2 files covered. (97.2%)

8672 of 10065 relevant lines covered (86.16%)

7840.89 hits per line