moonlibs / config / 6395745057

69%

master: 68%

Build Type

Pull #29

github

Committed by Vladislav Grubov

Commit Message

feat: support config.enforce_ro(true|false)

  * This method is needed for autofailover mechanisms mainly to enforce
    read_only=true during loading phase of tarantool.

  Before this patch race condition existed between autofailover and
  moonlibs/config recovering behaviour.

  If master crashes but fastly restartes then it initiates long running
  loading phase. Master recovers as read_only=true but after returning
  from box.cfg moonlibs/config retrieves config from ETCD and rechecks
  read_only option.

  This lead to situation when autofailover may change ETCD configuration
  when master is about to leave loading phase but autofailover already
  confirmed that master is "loading".

  Having method config.enforce_ro it is now possible for external
  autofailover to firstly enforce_ro of loading master and then change
  ETCD configuration and promote other candidate fixing races and
  stabilizes FSM

Pull Request Pull Request #29: draft: fixes fencing and hot-reload in 2.11+

Run Details

129 of 129 new or added lines in 2 files covered. (100.0%)

615 of 897 relevant lines covered (68.56%)

108.19 hits per line