stipsan / ioredis-mock / 6350674015

95%

master: 97%

push

github

fix: xread fixes (#1318)

* fix: stream and id order in xread command

The syntax for an XREAD command is

```
XREAD [COUNT count] [BLOCK milliseconds] STREAMS key [key ...] id
  [id ...]
```

Before this fix the implementation used

```
XREAD [COUNT count] [BLOCK milliseconds] STREAMS key id [key id...]
```

The new approach should be equally fast and provide the correct results. Also
adjusted existing tests.

Links:
https://redis.io/commands/xread/

* fix: BLOCKING behaviour to not return immediately

It needs to wait until the timeElapsed is greater or eq the defined blocking time.
The test was enhanced to spot the issue and verify the fix worked. This
uncovered another issue with the way found events are evaluated to always return
even without any event received. This problem is also fixed by this commit.

---------

Co-authored-by: Sven Sterbling <sven.sterbling@sap.com>

1152 of 1249 branches covered (0.0%)

6 of 6 new or added lines in 1 file covered. (100.0%)

1964 of 2058 relevant lines covered (95.43%)

2530.65 hits per line