GoogleCloudPlatform / ops-agent / 6331819346

88%

master: 88%

Pull #1449

github

Implement __match_ field deletion via modify

The existing lua chunk for deleting the temporary __match_ fields
relies on `match` being set, otherwise the code flows into the
`return 0, 0, 0` path which indicates the record hasn't been modified.

`return 0, 0, 0` is a nice optimization to have, and I'd rather not
remove it just for the sake of having the temp field deletion code
be lua, so this commit re-implements it as a plain `modify` filter.

Open to alternatives; the main point of this is to write a test for the
failing use case and propose a fix, which we can iterate on.

9 of 9 new or added lines in 1 file covered. (100.0%)

8824 of 9983 relevant lines covered (88.39%)

1.89 hits per line