shimming-toolbox / shimming-toolbox / 6328744441

90%

push

github

Add GE compatibility, spherical harmonic shim + refactoring of the Scanner shim coordinate systems (#476)

* Add ge_basis and refactor siemens_basis in a spherical harmonics basis file

* Add and change tests to reflect changes

* Update documentation

* Add GE to the allowed manufacturer to rescale the phase in read_nii, however it is not yet implemented

* Add GE to dcm2bids

* Typos

* Fix an error if a subject is called sub-xxxxx

* Refactor coordinate system to allow to easily introduce new Scanners

* Clearer math

* Clearer error message

* Plot improvements

* Fix wrongly named tests

* Specify logger to update and remove unecessary caplog in b1 tests

* Fix 1st order units

* Allow the Manufacturer tag to not be specified in the JSON sidecar

* Typo

156 of 173 new or added lines in 7 files covered. (90.17%)

4326 of 4618 relevant lines covered (93.68%)

3.75 hits per line