ooni / probe-cli / 6316582611

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(enginenetx): enable the stats-based policy (#1313)

This commit modifies the https-dialer policy we create to take into
account stats to generate tactics. As of this commit, the overall policy
is as follows:

1. if `$OONI_HOME/$engine_dir/httpsdialerstatic.conf` exists and
contains entries for the endpoint's domain (e.g.,
"www.example.com:443"), then we unconditionally use it to generate
tactics, otherwise;

2. we generate tactics using existing stats and filter only the tactics
that are less than one week old (filtering done when loading from the
kvstore) and have worked at least once, otherwise;

3. we generate tactics using known beacons and candidate SNIs with the
extra caveat that we're not going to generate a tactic we have generate
already in the previous step, otherwise;

4. we use whatever resolver is configured to lookup for the domain name
and generate tactics doing the boring thing of using the resolved IP
addrs along with the SNI being equal to the original domain.

Note that this diff fixes a previously untested for bug caused by trying
to obtain statistics for an unknow endpoint domain.

Part of https://github.com/ooni/probe/issues/2531

Run Details

16 of 16 new or added lines in 3 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

24033 of 29376 relevant lines covered (81.81%)

37.18 hits per line